[
https://issues.apache.org/jira/browse/HDFS-16840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636379#comment-17636379
]
ASF GitHub Bot commented on HDFS-16840:
---------------------------------------
tomscut commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027393176
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##########
@@ -101,8 +103,24 @@ public class OfflineImageViewerPB {
+ " against image file. (XML|FileDistribution|\n"
+ " ReverseXML|Web|Delimited|DetectCorruption)\n"
+ " The default is Web.\n"
+ + "-addr <arg> Specify the address(host:port) to listen.\n"
+ + " (localhost:5978 by default). This option is\n"
+ + " used with Web processor.\n"
+ + "-maxSize <arg> Specify the range [0, maxSize] of file sizes\n"
+ + " to be analyzed in bytes (128GB by default).\n"
+ + " This option is used with FileDistribution
processor.\n"
+ + "-step <arg> Specify the granularity of the distribution in
bytes\n"
+ + " (2MB by default). This option is used\n"
+ + " with FileDistribution processor.\n"
+ + "-format Format the output result in a human-readable
fashion rather\n"
+ + " than a number of bytes. (false by default).\n"
+ + " This option is used with FileDistribution
processor.\n"
+ "-delimiter <arg> Delimiting string to use with Delimited or \n"
+ " DetectCorruption processor. \n"
+ + "-sp Whether to print Storage policy (default is
false). \n"
+ + " Is used by Delimited processor only. \n"
+ + "-ec Whether to print Erasure coding policy
(default is false). \n"
Review Comment:
nit: `Storage policy` -> `storage policy`, `Erasure coding policy` ->
`erasure coding policy`.
> Enhance the usage description about oiv in HDFSCommands.md and
> OfflineImageViewerPB
> -----------------------------------------------------------------------------------
>
> Key: HDFS-16840
> URL: https://issues.apache.org/jira/browse/HDFS-16840
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> the usage description about oiv in OfflineImageViewerPB support print out
> storage and erasure coding policy id, -maxSize, -step, -format and -addr.
> maybe can add relevant information in HDFSCommands.md to describe how to use
> it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
