[
https://issues.apache.org/jira/browse/HDFS-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637493#comment-17637493
]
ASF GitHub Bot commented on HDFS-16851:
---------------------------------------
goiri commented on code in PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#discussion_r1029857848
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -97,6 +106,7 @@
public class RouterAdmin extends Configured implements Tool {
private static final Logger LOG = LoggerFactory.getLogger(RouterAdmin.class);
+ private static final String DUMP_COMMAND = "-dumpState";
Review Comment:
As you are at it, can you add a constant for all the others?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -1301,6 +1327,46 @@ private int refreshCallQueue() throws IOException {
return returnCode;
}
+ /**
+ * Dumps the contents of the StateStore to stdout.
+ * @return true if it was successful
+ */
+ public static boolean dumpStateStore(Configuration conf,
+ PrintStream output) throws IOException {
+ StateStoreService service = new StateStoreService();
+ conf.setBoolean(RBFConfigKeys.DFS_ROUTER_METRICS_ENABLE, false);
+ service.init(conf);
+ service.loadDriver();
+ if (!service.isDriverReady()) {
+ System.err.println("Can't initialize driver");
+ return false;
+ }
+ // Get the stores sorted by name
+ Map<String, RecordStore<? extends BaseRecord>> stores = new TreeMap<>();
+ for(RecordStore<? extends BaseRecord> store: service.getRecordStores()) {
+ stores.put(StateStoreUtils.getRecordName(store.getRecordClass()), store);
+ }
+ for (Entry<String, RecordStore<? extends BaseRecord>> pair:
stores.entrySet()) {
+ output.println(String.format("--
> RBF: Add a utility to dump the StateStore
> -----------------------------------------
>
> Key: HDFS-16851
> URL: https://issues.apache.org/jira/browse/HDFS-16851
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
> Labels: pull-request-available
>
> It would be useful to have a utility to dump the StateStore for RBF.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
