[ 
https://issues.apache.org/jira/browse/HDFS-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640220#comment-17640220
 ] 

ASF GitHub Bot commented on HDFS-16851:
---------------------------------------

omalley commented on code in PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#discussion_r1033968329


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -97,6 +106,7 @@
 public class RouterAdmin extends Configured implements Tool {
 
   private static final Logger LOG = LoggerFactory.getLogger(RouterAdmin.class);
+  private static final String DUMP_COMMAND = "-dumpState";

Review Comment:
   I considered it, but it will make this patch much larger and riskier. 
Additionally, it really should be refactored to use the HDFS AdminHelper 
utility class. I've filed 
[HDFS-16856](https://issues.apache.org/jira/browse/HDFS-16856) to address the 
relevant refactoring.





> RBF: Add a utility to dump the StateStore
> -----------------------------------------
>
>                 Key: HDFS-16851
>                 URL: https://issues.apache.org/jira/browse/HDFS-16851
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>              Labels: pull-request-available
>
> It would be useful to have a utility to dump the StateStore for RBF.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to