[
https://issues.apache.org/jira/browse/HDFS-16888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675841#comment-17675841
]
ASF GitHub Bot commented on HDFS-16888:
---------------------------------------
haiyang1987 commented on PR #5296:
URL: https://github.com/apache/hadoop/pull/5296#issuecomment-1379903904
Hi @ZanderXu @tomscut @tasanuma please help me review this minor changes
when you are available, Thanks.
> BlockManager#maxReplicationStreams, replicationStreamsHardLimit,
> blocksReplWorkMultiplier and PendingReconstructionBlocks#timeout should be
> volatile
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16888
> URL: https://issues.apache.org/jira/browse/HDFS-16888
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> BlockManager#maxReplicationStreams, replicationStreamsHardLimit,
> blocksReplWorkMultiplier and PendingReconstructionBlocks#timeout these
> variables may be writen by NameNode#reconfReplicationParameters then while
> read by the other threads.
> Thus they should be declared as volatile to make sure the "happens-before"
> consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
