[ https://issues.apache.org/jira/browse/HDFS-16888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680470#comment-17680470 ]
ASF GitHub Bot commented on HDFS-16888: --------------------------------------- tomscut commented on PR #5296: URL: https://github.com/apache/hadoop/pull/5296#issuecomment-1403184129 Hi @haiyang1987 , because this PR is quite old, can you rebase it? Thank you. > BlockManager#maxReplicationStreams, replicationStreamsHardLimit, > blocksReplWorkMultiplier and PendingReconstructionBlocks#timeout should be > volatile > ---------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-16888 > URL: https://issues.apache.org/jira/browse/HDFS-16888 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haiyang Hu > Assignee: Haiyang Hu > Priority: Major > Labels: pull-request-available > > BlockManager#maxReplicationStreams, replicationStreamsHardLimit, > blocksReplWorkMultiplier and PendingReconstructionBlocks#timeout these > variables may be writen by NameNode#reconfReplicationParameters then while > read by the other threads. > Thus they should be declared as volatile to make sure the "happens-before" > consistency. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org