[ 
https://issues.apache.org/jira/browse/HDFS-16904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685994#comment-17685994
 ] 

ASF GitHub Bot commented on HDFS-16904:
---------------------------------------

steveloughran commented on PR #5342:
URL: https://github.com/apache/hadoop/pull/5342#issuecomment-1422976653

   ok, i got this wrong; should have said use 
o.a.hadoop.utils.IOUtils.closeStream(), because that one logs at debug if an 
exception is raised; this PR uses the o.a.commons.IOUtils (joy!) so doesn't log 
on a failure of that close(). The patch still works, but I'd like to be 
consistent. 
   
   Proposed: a followup patch, same JIRA, which moves to the o.a.h method; i 
will then backport the pair into branch-3.
   
   sorry for adding extra homework




> Close webhdfs during the teardown
> ---------------------------------
>
>                 Key: HDFS-16904
>                 URL: https://issues.apache.org/jira/browse/HDFS-16904
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: hdfs
>    Affects Versions: 3.4.0, 3.3.5, 3.3.9
>         Environment: Tested using the Hadoop development environment Docker 
> image.
>            Reporter: Steve Vaughan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0, 3.3.9
>
>
> The teardown for the tests shutdown the cluster, but leaves HDFS open.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to