[ 
https://issues.apache.org/jira/browse/HDFS-16904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686361#comment-17686361
 ] 

ASF GitHub Bot commented on HDFS-16904:
---------------------------------------

steveloughran commented on code in PR #5372:
URL: https://github.com/apache/hadoop/pull/5372#discussion_r1101277484


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfs.java:
##########
@@ -100,7 +100,7 @@ public static void afterClassTeardown() throws Exception {
     if (cluster != null) {
       cluster.shutdown();
     }
-    IOUtils.closeQuietly(webhdfs);
+    IOUtils.closeStream(webhdfs);

Review Comment:
   realy, I always thought closeStream() would pass in the default logger if 
none set. If that is *not the case* then we should fix it...it gets used in a 
lot of places





> Close webhdfs during the teardown
> ---------------------------------
>
>                 Key: HDFS-16904
>                 URL: https://issues.apache.org/jira/browse/HDFS-16904
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: hdfs
>    Affects Versions: 3.4.0, 3.3.5, 3.3.9
>         Environment: Tested using the Hadoop development environment Docker 
> image.
>            Reporter: Steve Vaughan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0, 3.3.9
>
>
> The teardown for the tests shutdown the cluster, but leaves HDFS open.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to