[
https://issues.apache.org/jira/browse/HDFS-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704256#comment-17704256
]
ASF GitHub Bot commented on HDFS-16959:
---------------------------------------
virajjasani commented on code in PR #5497:
URL: https://github.com/apache/hadoop/pull/5497#discussion_r1146493478
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/driver/TestStateStoreDriverBase.java:
##########
@@ -574,6 +580,26 @@ private static Map<String, Class<?>> getFields(BaseRecord
record) {
return getters;
}
+ public void testCacheLoadMetrics(StateStoreDriver driver, int numRefresh)
+ throws IOException, IllegalArgumentException {
+ StateStoreMetrics metrics = stateStore.getMetrics();
+ final Query<MountTable> query = new Query<>(MountTable.newInstance());
+ driver.getMultiple(MountTable.class, query);
+ final Map<String, MutableRate> cacheLoadMetrics =
metrics.getCacheLoadMetrics();
+ final MutableRate mountTableCache =
cacheLoadMetrics.get("CacheMountTableLoad");
+ assertNotNull("CacheMountTableLoad should be present in the state store
metrics",
+ mountTableCache);
+ // CacheMountTableLoadNumOps
+ final long mountTableCacheLoadNumOps =
mountTableCache.lastStat().numSamples();
+ assertEquals("Num of samples collected should match with " + numRefresh +
". Actual value: "
+ + mountTableCacheLoadNumOps, numRefresh, mountTableCacheLoadNumOps);
+ // CacheMountTableLoadAvgTime
+ final double mountTableCacheLoadAvgTime =
mountTableCache.lastStat().mean();
+ assertTrue(
+ "Mean time duration for cache load is expected to be less than 2000
ms. Actual value: "
+ + mountTableCacheLoadAvgTime, mountTableCacheLoadAvgTime < 2000d);
Review Comment:
Done
> RBF: State store cache loading metrics
> --------------------------------------
>
> Key: HDFS-16959
> URL: https://issues.apache.org/jira/browse/HDFS-16959
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> With increasing num of state store records (like mount points), it would be
> good to be able to get the cache loading metrics like avg time for cache load
> during refresh, num of times cache is loaded etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
