[
https://issues.apache.org/jira/browse/HDFS-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704257#comment-17704257
]
ASF GitHub Bot commented on HDFS-16959:
---------------------------------------
virajjasani commented on code in PR #5497:
URL: https://github.com/apache/hadoop/pull/5497#discussion_r1146494308
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/driver/TestStateStoreZK.java:
##########
@@ -206,4 +206,13 @@ public void testFetchErrors()
stateStoreDriver.setEnableConcurrent(true);
testFetchErrors(stateStoreDriver);
}
+
+ @Test
+ public void testCacheLoadMetrics() throws IOException {
+ getStateStoreService().refreshCaches(true);
+ getStateStoreService().refreshCaches(true);
+ getStateStoreService().refreshCaches(true);
+ testCacheLoadMetrics(getStateStoreDriver(), 4);
Review Comment:
Ah yes, I updated it to increment on whatever is the current num of loads.
Thanks for pointing this out Ayush!
> RBF: State store cache loading metrics
> --------------------------------------
>
> Key: HDFS-16959
> URL: https://issues.apache.org/jira/browse/HDFS-16959
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> With increasing num of state store records (like mount points), it would be
> good to be able to get the cache loading metrics like avg time for cache load
> during refresh, num of times cache is loaded etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
