[
https://issues.apache.org/jira/browse/HDFS-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709582#comment-17709582
]
ASF GitHub Bot commented on HDFS-16972:
---------------------------------------
szetszwo commented on PR #5532:
URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1499923239
> ... when call reaches here, the snapshot id is CURRENT_STATE_ID, which
represent current state. Why are we proceeding to clean subtree originally with
CURRENT_STATE_ID. Could you provide more details on that? ...
The might be a bug. `prior` and `snapshot` are supposed to be the prior and
the current Snapshot IDs. Because of rename, the subtree was moved from
somewhere to there. The logic in `getPriorSnapshot` and `getSelfSnapshot` may
be incorrect.
> Delete a snapshot may deleteCurrentFile
> ---------------------------------------
>
> Key: HDFS-16972
> URL: https://issues.apache.org/jira/browse/HDFS-16972
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: snapshots
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
>
> We found one case the when deleting a snapshot (with ordered snapshot
> deletion disabled), it can incorrectly delete some files in the current state.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
