[
https://issues.apache.org/jira/browse/HDFS-16975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711445#comment-17711445
]
ASF GitHub Bot commented on HDFS-16975:
---------------------------------------
szetszwo opened a new pull request, #5546:
URL: https://github.com/apache/hadoop/pull/5546
### Description of PR
FileWithSnapshotFeature.isCurrentFileDeleted is not serialized to FSImage.
If it is true for any files, it will becomes false after saving to a FSImage
and loading it back.
We will fix it by checking `isInCurrentState()` when loading FSImage.
https://issues.apache.org/jira/browse/HDFS-16975
### How was this patch tested?
Added "isCurrentFileDeleted" to `FileWithSnapshotFeature.toString()`. Then,
`TestFSImageWithSnapshot.testSaveLoadImage()` will fail without the fix.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [NA] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [NA] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [NA] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> FileWithSnapshotFeature.isCurrentFileDeleted is not reloaded from FSImage.
> --------------------------------------------------------------------------
>
> Key: HDFS-16975
> URL: https://issues.apache.org/jira/browse/HDFS-16975
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namanode
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
>
> FileWithSnapshotFeature.isCurrentFileDeleted is not serialized to FSImage.
> If it is true for any files, it will becomes false after saving to a FSImage
> and loading it back.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
