[
https://issues.apache.org/jira/browse/HDFS-16975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714639#comment-17714639
]
ASF GitHub Bot commented on HDFS-16975:
---------------------------------------
umamaheswararao commented on code in PR #5546:
URL: https://github.com/apache/hadoop/pull/5546#discussion_r1172773692
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java:
##########
@@ -458,7 +452,16 @@ public FileWithSnapshotFeature
addSnapshotFeature(FileDiffList diffs) {
this.addFeature(sf);
return sf;
}
-
+
+ /** Used by FSImage. */
+ public INodeFile loadSnapshotFeature(FileDiffList diffs) {
+ final FileWithSnapshotFeature sf = addSnapshotFeature(diffs);
Review Comment:
Since this was not persisted before, we are just making sure while loading
back by having the below check. Is my understanding correct?
> FileWithSnapshotFeature.isCurrentFileDeleted is not reloaded from FSImage.
> --------------------------------------------------------------------------
>
> Key: HDFS-16975
> URL: https://issues.apache.org/jira/browse/HDFS-16975
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namanode
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
>
> FileWithSnapshotFeature.isCurrentFileDeleted is not serialized to FSImage.
> If it is true for any files, it will becomes false after saving to a FSImage
> and loading it back.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
