[
https://issues.apache.org/jira/browse/HDFS-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714756#comment-17714756
]
ASF GitHub Bot commented on HDFS-16936:
---------------------------------------
ayushtkn commented on code in PR #5438:
URL: https://github.com/apache/hadoop/pull/5438#discussion_r1173088657
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:
##########
@@ -288,7 +286,7 @@ void cleanUp() throws IOException {
clientProto.setSafeMode(HdfsConstants.SafeModeAction.SAFEMODE_LEAVE,
false);
if(!keepResults)
- clientProto.delete(getBaseDir(), true);
+ clientProto.delete(getWorkDir(), true);
Review Comment:
Why workdir now?
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:
##########
@@ -228,7 +227,6 @@ abstract class OperationStatsBase {
abstract void printResults();
OperationStatsBase() {
- baseDir = BASE_DIR_NAME + "/" + getOpName();
Review Comment:
should have been getBaseDir() + "/" + getOpName();?
> Add baseDir option in NNThroughputBenchmark
> -------------------------------------------
>
> Key: HDFS-16936
> URL: https://issues.apache.org/jira/browse/HDFS-16936
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Mark Bukhner
> Priority: Trivial
> Labels: pull-request-available
>
> Now it's impossible to configure directory path using by
> {*}NNThroughputBenchmark{*}.
> This improvement is helpful in *RBF* features testing.
> Example of usage:
> {code:java}
> sudo bin/hadoop org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark
> -fs ... -op create -threads 16 -baseDir /cluster1{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
