[
https://issues.apache.org/jira/browse/HDFS-16865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714758#comment-17714758
]
ASF GitHub Bot commented on HDFS-16865:
---------------------------------------
ayushtkn commented on code in PR #5200:
URL: https://github.com/apache/hadoop/pull/5200#discussion_r1173115347
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java:
##########
@@ -979,7 +979,10 @@ public boolean complete(String src, String clientName,
ExtendedBlock last, long fileId)
throws IOException {
checkNNStartup();
- return namesystem.completeFile(src, clientName, last, fileId);
+ boolean result = namesystem.completeFile(src, clientName, last, fileId);
+ LOG.debug("*DIR* NameNode.complete: src={}, clientName={}, fileId={},
result={}.",
+ src, clientName, fileId, result);
+ return result;
Review Comment:
The `namesystem.completeFile` already logs in into the stateChange log
```
NameNode.stateChangeLog.info("DIR* completeFile: " + src
+ " is closed by " + holder);
```
I don't think you need this change in this scope. In general complete
changes the Fs state so it uses ``stateChangeLog`` if any API changes block
state it uses ``blockStateChangeLog`` for rest snapshot or EC operations it is
normal log
> RBF: The source path is always / after RBF proxied the complete, addBlock and
> getAdditionalDatanode RPC.
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16865
> URL: https://issues.apache.org/jira/browse/HDFS-16865
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> The source path is always / after RBF proxied the complete, addBlock and
> getAdditionalDatanode RPC.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
