[ 
https://issues.apache.org/jira/browse/HDFS-16865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715388#comment-17715388
 ] 

ASF GitHub Bot commented on HDFS-16865:
---------------------------------------

ZanderXu commented on code in PR #5200:
URL: https://github.com/apache/hadoop/pull/5200#discussion_r1174517134


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java:
##########
@@ -979,7 +979,10 @@ public boolean complete(String src, String clientName,
                           ExtendedBlock last,  long fileId)
       throws IOException {
     checkNNStartup();
-    return namesystem.completeFile(src, clientName, last, fileId);
+    boolean result = namesystem.completeFile(src, clientName, last, fileId);
+    LOG.debug("*DIR* NameNode.complete: src={}, clientName={}, fileId={}, 
result={}.",
+        src, clientName, fileId, result);
+    return result;

Review Comment:
   @ayushtkn Master, thanks for your review.  I have updated this PR, please 
help me review it again when you are available. Thanks 
   
   





> RBF: The source path is always / after RBF proxied the complete, addBlock and 
> getAdditionalDatanode RPC.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-16865
>                 URL: https://issues.apache.org/jira/browse/HDFS-16865
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Major
>              Labels: pull-request-available
>
> The source path is always / after RBF proxied the complete, addBlock and 
> getAdditionalDatanode RPC.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to