[ 
https://issues.apache.org/jira/browse/HDFS-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740932#comment-17740932
 ] 

ASF GitHub Bot commented on HDFS-17068:
---------------------------------------

Hexiaoqiao commented on code in PR #5809:
URL: https://github.com/apache/hadoop/pull/5809#discussion_r1255390061


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/FSDatasetMBean.java:
##########
@@ -122,4 +122,9 @@ public interface FSDatasetMBean extends MetricsSource {
    * Returns the number of blocks that the datanode was unable to uncache
    */
   public long getNumBlocksFailedToUncache();
+
+  /**
+   * Returns the last time in milliseconds of directory scanner run.
+   */
+  public long getLastDirectoryScannerRunTime();

Review Comment:
   This name will be little misleading if it is the begin or end time of one 
loop of DirectoryScanner.





> Datanode should record last directory scan time.
> ------------------------------------------------
>
>                 Key: HDFS-17068
>                 URL: https://issues.apache.org/jira/browse/HDFS-17068
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Minor
>              Labels: pull-request-available
>
> I think it is useful for us to record last directory scan time for one 
> datanode. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to