[
https://issues.apache.org/jira/browse/HDFS-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741145#comment-17741145
]
ASF GitHub Bot commented on HDFS-17068:
---------------------------------------
xinglin commented on code in PR #5809:
URL: https://github.com/apache/hadoop/pull/5809#discussion_r1256166496
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3811,5 +3818,10 @@ void stopAllDataxceiverThreads(FsVolumeImpl volume) {
public List<FsVolumeImpl> getVolumeList() {
return volumes.getVolumes();
}
+
+ @Override
+ public void updateLastDirScannerFinishTime(long time) {
Review Comment:
nit: can we rename to `setLastDirScannerFinishTime`, following the
getter/setter convention?
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetricHelper.java:
##########
@@ -72,8 +71,10 @@ public static void getMetrics(MetricsCollector collector,
"blocks failed to cache"), beanClass.getNumBlocksFailedToCache())
.addGauge(Interns.info("NumBlocksFailedToUnCache", "Datanode number of" +
" blocks failed in cache eviction"),
- beanClass.getNumBlocksFailedToUncache());
-
+ beanClass.getNumBlocksFailedToUncache())
+ .addGauge(Interns.info("LastDirectoryScannerFinishTime",
+ "Last finish time of directory scanner"),
Review Comment:
"Last finish time of directory scanner" -> "Finish time of the last
directory **scan**".
I would actually prefer "most recent" over "last", but fine with "last".
> Datanode should record last directory scan time.
> ------------------------------------------------
>
> Key: HDFS-17068
> URL: https://issues.apache.org/jira/browse/HDFS-17068
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
> I think it is useful for us to record last directory scan time for one
> datanode.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
