[
https://issues.apache.org/jira/browse/HDFS-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741892#comment-17741892
]
ASF GitHub Bot commented on HDFS-17068:
---------------------------------------
ayushtkn commented on code in PR #5809:
URL: https://github.com/apache/hadoop/pull/5809#discussion_r1259331408
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java:
##########
@@ -250,6 +250,13 @@ public void checkDataSetLockManager() {
assertNull(manager.getLastException());
}
+ @Test
+ public void testSetLastDirScannerFinishTime() throws IOException {
+ assertEquals(dataset.getLastDirScannerFinishTime(), 0L);
+ dataset.setLastDirScannerFinishTime(System.currentTimeMillis());
+ assertNotEquals(0L, dataset.getLastDirScannerFinishTime());
+ }
Review Comment:
not this test, add a Test for DirectoryScanner
> Datanode should record last directory scan time.
> ------------------------------------------------
>
> Key: HDFS-17068
> URL: https://issues.apache.org/jira/browse/HDFS-17068
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
> I think it is useful for us to record last directory scan time for one
> datanode.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
