[
https://issues.apache.org/jira/browse/HDFS-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741396#comment-17741396
]
ASF GitHub Bot commented on HDFS-17068:
---------------------------------------
Hexiaoqiao commented on code in PR #5809:
URL: https://github.com/apache/hadoop/pull/5809#discussion_r1257496803
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java:
##########
@@ -477,4 +482,7 @@ public MountVolumeMap getMountVolumeMap() {
public List<FsVolumeImpl> getVolumeList() {
return null;
}
+
+ @Override
+ public void setLastDirScannerFinishTime(long time) {}
Review Comment:
+1, I am also confused why this behavior is different with
ExternalDatasetImpl#setLastDirScannerFinishTime.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3811,5 +3817,10 @@ void stopAllDataxceiverThreads(FsVolumeImpl volume) {
public List<FsVolumeImpl> getVolumeList() {
return volumes.getVolumes();
}
+
+ @Override
+ public void setLastDirScannerFinishTime(long time) {
Review Comment:
suggest to locate getter/setter to be next each other.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java:
##########
@@ -692,4 +692,6 @@ ReplicaInfo moveBlockAcrossVolumes(final ExtendedBlock
block,
* Get the volume list.
*/
List<FsVolumeImpl> getVolumeList();
+
+ void setLastDirScannerFinishTime(long time);
Review Comment:
Just suggest to add some javadocs.
> Datanode should record last directory scan time.
> ------------------------------------------------
>
> Key: HDFS-17068
> URL: https://issues.apache.org/jira/browse/HDFS-17068
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
> I think it is useful for us to record last directory scan time for one
> datanode.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
