[
https://issues.apache.org/jira/browse/HDFS-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751469#comment-17751469
]
ASF GitHub Bot commented on HDFS-17140:
---------------------------------------
Hexiaoqiao commented on code in PR #5924:
URL: https://github.com/apache/hadoop/pull/5924#discussion_r1285417874
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java:
##########
@@ -291,10 +291,11 @@ public String toString() {
void reportBadBlocks(ExtendedBlock block,
String storageUuid, StorageType storageType) {
checkBlock(block);
- for (BPServiceActor actor : bpServices) {
- ReportBadBlockAction rbbAction = new ReportBadBlockAction
- (block, storageUuid, storageType);
- actor.bpThreadEnqueue(rbbAction);
+ if (!bpServices.isEmpty()) {
Review Comment:
Could it be empty? What issue do you meet here? Thanks.
> Optimize the BPOfferService.reportBadBlocks() method
> ----------------------------------------------------
>
> Key: HDFS-17140
> URL: https://issues.apache.org/jira/browse/HDFS-17140
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Liangjun He
> Assignee: Liangjun He
> Priority: Minor
> Labels: pull-request-available
>
> The current BPOfferService.reportBadBlocks() method can be optimized by
> moving the creation of the rbbAction object outside the loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
