[
https://issues.apache.org/jira/browse/HDFS-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752635#comment-17752635
]
ASF GitHub Bot commented on HDFS-17140:
---------------------------------------
2005hithlj commented on code in PR #5924:
URL: https://github.com/apache/hadoop/pull/5924#discussion_r1285727589
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java:
##########
@@ -291,10 +291,11 @@ public String toString() {
void reportBadBlocks(ExtendedBlock block,
String storageUuid, StorageType storageType) {
checkBlock(block);
- for (BPServiceActor actor : bpServices) {
- ReportBadBlockAction rbbAction = new ReportBadBlockAction
- (block, storageUuid, storageType);
- actor.bpThreadEnqueue(rbbAction);
+ if (!bpServices.isEmpty()) {
Review Comment:
@Hexiaoqiao sir, BPServices will definitely not be empty here, I will remove
this judgment.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java:
##########
@@ -291,9 +291,8 @@ public String toString() {
void reportBadBlocks(ExtendedBlock block,
String storageUuid, StorageType storageType) {
checkBlock(block);
+ ReportBadBlockAction rbbAction = new ReportBadBlockAction(block,
storageUuid, storageType);
Review Comment:
@slfan1989 This improvement may not have much effect, but it does reduce
the creation of redundant and useless temporary objects. At the same time, from
the perspective of code style, the implementation here is not elegant.
> Optimize the BPOfferService.reportBadBlocks() method
> ----------------------------------------------------
>
> Key: HDFS-17140
> URL: https://issues.apache.org/jira/browse/HDFS-17140
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Liangjun He
> Assignee: Liangjun He
> Priority: Minor
> Labels: pull-request-available
>
> The current BPOfferService.reportBadBlocks() method can be optimized by
> moving the creation of the rbbAction object outside the loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
