[
https://issues.apache.org/jira/browse/HDFS-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202148#comment-13202148
]
Aaron T. Myers commented on HDFS-2586:
--------------------------------------
If Jitendra hadn't noticed the lack of KerberosInfo annotations, secure
communication wouldn't have worked. Even though you've added them, their values
being correct aren't covered at all by the tests.
Another, similar change recently inadvertently broke several protocols because
of some unintended consequences due to static initialization of RPC engines.
This didn't show up in the tests because all daemons run in the same JVM, and
thus static initialization for one will cover all.
If we had a multi-process minicluster, or any support for automated testing
with security enabled, I'd agree with you that running the automated tests
would be sufficient. In lieu of that, please test this change manually.
> Add protobuf service and implementation for HAServiceProtocol
> -------------------------------------------------------------
>
> Key: HDFS-2586
> URL: https://issues.apache.org/jira/browse/HDFS-2586
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2586.txt, HDFS-2586.txt
>
>
> When the trunk moves to protobuf based RPC, HAServiceProtocol should have
> equivalent protobuf implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
