[
https://issues.apache.org/jira/browse/HDFS-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210116#comment-13210116
]
Aaron T. Myers commented on HDFS-2586:
--------------------------------------
I tested out the latest patch with and without security enabled, and it worked
like a charm.
One tiny nit: I'd swap the order of the "INITIALIZING" and "default" cases in
the switch statement in
{{HAServiceProtocolServerSideTranslatorPB#getServiceState}}, so that "default"
comes last.
+1 otherwise.
Thanks a lot for taking care of this, Suresh.
> Add protobuf service and implementation for HAServiceProtocol
> -------------------------------------------------------------
>
> Key: HDFS-2586
> URL: https://issues.apache.org/jira/browse/HDFS-2586
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2586.txt, HDFS-2586.txt, HDFS-2586.txt
>
>
> When the trunk moves to protobuf based RPC, HAServiceProtocol should have
> equivalent protobuf implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira