[ 
https://issues.apache.org/jira/browse/HDFS-17362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811706#comment-17811706
 ] 

ASF GitHub Bot commented on HDFS-17362:
---------------------------------------

tasanuma opened a new pull request, #6510:
URL: https://github.com/apache/hadoop/pull/6510

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   Currently, RouterObserverReadProxyProvider is using IPFailoverProxyProvider, 
while ObserverReadProxyProvider is using ConfiguredFailoverProxyProvider.  If 
we are to align RouterObserverReadProxyProvider with ObserverReadProxyProvider, 
RouterObserverReadProxyProvider should internally use 
ConfiguredFailoverProxyProvider.  Moreover, IPFailoverProxyProvider has an 
issue with resolving HA configurations. (For example, IPFailoverProxyProvider 
cannot resolve hdfs://router-service.)
   
   ### How was this patch tested?
   
   `mvn test -Dtest=TestObserverWithRouter` succeeded in my local computer.
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   




> RBF: RouterObserverReadProxyProvider should use 
> ConfiguredFailoverProxyProvider internally
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17362
>                 URL: https://issues.apache.org/jira/browse/HDFS-17362
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>
> Currently, RouterObserverReadProxyProvider is using IPFailoverProxyProvider, 
> while ObserverReadProxyProvider is using ConfiguredFailoverProxyProvider.  If 
> we are to align RouterObserverReadProxyProvider with 
> ObserverReadProxyProvider, RouterObserverReadProxyProvider should internally 
> use ConfiguredFailoverProxyProvider.  Moreover, IPFailoverProxyProvider has 
> an issue with resolving HA configurations. (For example, 
> IPFailoverProxyProvider cannot resolve hdfs://router-service.)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to