[
https://issues.apache.org/jira/browse/HDFS-17362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812582#comment-17812582
]
ASF GitHub Bot commented on HDFS-17362:
---------------------------------------
tasanuma commented on PR #6510:
URL: https://github.com/apache/hadoop/pull/6510#issuecomment-1918665891
@ayushtkn Thanks for the review. I've updated the PR to use
`RouterObserverReadProxyProvider.class` in the logger.
It seems that `RouterObserverReadProxyProvider` is simpler than
`ObserverReadProxyProvider` as Router is handling some tasks for it. So,
extending `ObserverReadProxyProvider` might not be the best approach. Indeed,
there are some common fields and methods such as `autoMsyncIfNecessary()`, so
creating an abstract class or an interface could be a good idea. I would like
to hear @simbadzina 's opinion on this.
By the way, @chunyiyang is actually a woman. :)
> RBF: RouterObserverReadProxyProvider should use
> ConfiguredFailoverProxyProvider internally
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-17362
> URL: https://issues.apache.org/jira/browse/HDFS-17362
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Labels: pull-request-available
>
> Currently, RouterObserverReadProxyProvider is using IPFailoverProxyProvider,
> while ObserverReadProxyProvider is using ConfiguredFailoverProxyProvider. If
> we are to align RouterObserverReadProxyProvider with
> ObserverReadProxyProvider, RouterObserverReadProxyProvider should internally
> use ConfiguredFailoverProxyProvider. Moreover, IPFailoverProxyProvider has
> an issue with resolving HA configurations. (For example,
> IPFailoverProxyProvider cannot resolve hdfs://router-service.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
