[
https://issues.apache.org/jira/browse/HDFS-17362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813553#comment-17813553
]
ASF GitHub Bot commented on HDFS-17362:
---------------------------------------
simbadzina commented on code in PR #6510:
URL: https://github.com/apache/hadoop/pull/6510#discussion_r1475695932
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/RouterObserverReadProxyProvider.java:
##########
@@ -84,7 +84,8 @@ public class RouterObserverReadProxyProvider<T> extends
AbstractNNFailoverProxyP
public RouterObserverReadProxyProvider(Configuration conf, URI uri, Class<T>
xface,
HAProxyFactory<T> factory) {
- this(conf, uri, xface, factory, new IPFailoverProxyProvider<>(conf, uri,
xface, factory));
+ this(conf, uri, xface, factory,
+ new ConfiguredFailoverProxyProvider<>(conf, uri, xface, factory));
Review Comment:
For a different internal proxyprovider we have code like below.
```
this(conf, uri, xface, proxyFactory, getFailoverProxyProvider(conf, uri,
xface, proxyFactory));
```
and
```
@VisibleForTesting
protected static <T> AbstractNNFailoverProxyProvider<T>
getFailoverProxyProvider(
Configuration conf, URI uri, Class<T> xface, HAProxyFactory<T>
proxyFactory) {
String configKey = FAILOVER_PROXY_PROVIDER + "." + uri.getHost();
Class<AbstractNNFailoverProxyProvider<T>> fppClass =
(Class<AbstractNNFailoverProxyProvider<T>>) conf.getClass(configKey,
(Class<? extends AbstractNNFailoverProxyProvider>)
DEFAULT_FAILOVER_PROXY_PROVIDER,
AbstractNNFailoverProxyProvider.class);
try {
Constructor<AbstractNNFailoverProxyProvider<T>> ctor =
fppClass.getConstructor(
Configuration.class, URI.class, Class.class, HAProxyFactory.class);
return ctor.newInstance(conf, uri, xface, proxyFactory);
} catch (Exception e) {
LOG.error("Failed to create failover proxy provider", e);
throw new IllegalArgumentException(e);
}
}
```
> RBF: RouterObserverReadProxyProvider should use
> ConfiguredFailoverProxyProvider internally
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-17362
> URL: https://issues.apache.org/jira/browse/HDFS-17362
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Labels: pull-request-available
>
> Currently, RouterObserverReadProxyProvider is using IPFailoverProxyProvider,
> while ObserverReadProxyProvider is using ConfiguredFailoverProxyProvider. If
> we are to align RouterObserverReadProxyProvider with
> ObserverReadProxyProvider, RouterObserverReadProxyProvider should internally
> use ConfiguredFailoverProxyProvider. Moreover, IPFailoverProxyProvider has
> an issue with resolving HA configurations. (For example,
> IPFailoverProxyProvider cannot resolve hdfs://router-service.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
