[
https://issues.apache.org/jira/browse/HDFS-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854973#comment-17854973
]
ASF GitHub Bot commented on HDFS-17439:
---------------------------------------
sodonnel commented on PR #6677:
URL: https://github.com/apache/hadoop/pull/6677#issuecomment-2167523722
@fateh288 there are still some checkstyle violations on lines that are
changed in this PR:
```
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:178:
protected boolean nonSuperUser = false; // enter/exit safe mode:23:
Variable 'nonSuperUser' must be private and have accessor methods.
[VisibilityModifier]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1044:
DatanodeStorage storage; //only one storage:21: Variable 'storage' must be
private and have accessor methods. [VisibilityModifier]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1177:
private int transferBlocks( Block blocks[],:31: '(' is followed by
whitespace. [ParenPad]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1177:
private int transferBlocks( Block blocks[],:39: 'blocks' hides a field.
[HiddenField]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1177:
private int transferBlocks( Block blocks[],:45: Array brackets at illegal
position. [ArrayTypeStyle]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:1298:
LOG.error("Potentially insufficient permission: try running the tool
with -nonSuperUser argument or login as super user");: Line is longer than 100
characters (found 132). [LineLength]
```
If you could address these, we are good to commit this.
> Improve NNThroughputBenchmark to allow non super user to use the tool
> ---------------------------------------------------------------------
>
> Key: HDFS-17439
> URL: https://issues.apache.org/jira/browse/HDFS-17439
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: benchmarks, namenode
> Reporter: Fateh Singh
> Priority: Major
> Labels: pull-request-available
>
> The NNThroughputBenchmark can only be used with hdfs user or any user with
> super user privileges since entering/exiting safemode is a privileged
> operation. However, when using super user, ACL checks are skipped. Hence it
> renders the tool to be useless when testing namenode performance along with
> authorization frameworks such as Apache Ranger / any other authorization
> frameworks.
> An optional argument such as -nonSuperUser can be used to skip the statements
> such as entering / exiting safemode. This optional argument makes the tool
> useful for incorporating authorization frameworks into the performance
> estimation flows.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
