[
https://issues.apache.org/jira/browse/HDFS-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855077#comment-17855077
]
ASF GitHub Bot commented on HDFS-17439:
---------------------------------------
fateh288 commented on PR #6677:
URL: https://github.com/apache/hadoop/pull/6677#issuecomment-2168169981
@sodonnel
The style checks while suggested otherwise from CI process are not really
from this commit (e.g. 2,3,4,5) if we look closely or are not blockers (e.g. 1)
. I have fixed number 6.
Style error 1: -nonSuperUser is protected and is in-line with other similar
member variables of the class.
Style error 2: not related to PR. Only whitespace removed from line for
style check
Style error 3,4,5: not related to PR. Only whitespace removed from this line
for an existing style check violation which I fixed
Style error 6: Line is longer than 100 characters
> Improve NNThroughputBenchmark to allow non super user to use the tool
> ---------------------------------------------------------------------
>
> Key: HDFS-17439
> URL: https://issues.apache.org/jira/browse/HDFS-17439
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: benchmarks, namenode
> Reporter: Fateh Singh
> Priority: Major
> Labels: pull-request-available
>
> The NNThroughputBenchmark can only be used with hdfs user or any user with
> super user privileges since entering/exiting safemode is a privileged
> operation. However, when using super user, ACL checks are skipped. Hence it
> renders the tool to be useless when testing namenode performance along with
> authorization frameworks such as Apache Ranger / any other authorization
> frameworks.
> An optional argument such as -nonSuperUser can be used to skip the statements
> such as entering / exiting safemode. This optional argument makes the tool
> useful for incorporating authorization frameworks into the performance
> estimation flows.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
