[
https://issues.apache.org/jira/browse/HDFS-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908760#comment-17908760
]
ASF GitHub Bot commented on HDFS-17699:
---------------------------------------
KeeProMise commented on PR #7254:
URL: https://github.com/apache/hadoop/pull/7254#issuecomment-2564989152
> @Hexiaoqiao @KeeProMise Sir, please help review this PR when you have free
time, Thanks a lot. By the way, I think asyncCallCounter field is useless if
this PR applied. What's your opinions.
Hi, @hfutatzhanghb, thanks for your contribution. Functionally, I don't see
any issues; however, in terms of implementation, I think we could manage an
attribute called asyncCallCounter within each connect instance to control the
maximum number of calls for that connect. This approach would eliminate the
need for the asyncCallCounters map, where each remoteId corresponds to a
connect object. Moreover, the connect object can be removed, but the
asyncCallCounters map can only add data and cannot delete it. I also think
asyncCallCounter field is useless if this PR applied.
> [ARR] Avoid adding calls indefinitely make Router Out-of-Memory.
> ----------------------------------------------------------------
>
> Key: HDFS-17699
> URL: https://issues.apache.org/jira/browse/HDFS-17699
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
