[jira] [Commented] (HDFS-17699) [ARR] Avoid adding calls indefinitely make Router Out-of-Memory.

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/HDFS-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908762#comment-17908762
 ] 

ASF GitHub Bot commented on HDFS-17699:
---------------------------------------

KeeProMise commented on code in PR #7254:
URL: https://github.com/apache/hadoop/pull/7254#discussion_r1899255240


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1246,6 +1249,7 @@ private void receiveRpcResponse() {
         if (status == RpcStatusProto.SUCCESS) {
           Writable value = packet.newInstance(valueClass, conf);
           final Call call = calls.remove(callId);
+          releaseAsyncCallPermit();

Review Comment:
   I think we can add a removeCall method in the connect class, and modify the 
existing addCall method to include a checkAsyncCall function.
   ```java
       /**
        * Add a call to this connection's call queue and notify
        * a listener; synchronized.
        * Returns false if called during shutdown.
        * @param call to add
        * @return true if the call was added.
        */
       private synchronized boolean addCall(Call call) {
         if (shouldCloseConnection.get())
           return false;
         checkAsyncCall();
         calls.put(call.id, call);
         notify();
         return true;
       }
   
       private void removeCall(int callId) {
           final Call call = calls.remove(callId);
           releaseAsyncCallPermit();
       }
   ```





> [ARR] Avoid adding calls indefinitely make Router Out-of-Memory.
> ----------------------------------------------------------------
>
>                 Key: HDFS-17699
>                 URL: https://issues.apache.org/jira/browse/HDFS-17699
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org