[
https://issues.apache.org/jira/browse/HDFS-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938190#comment-17938190
]
ASF GitHub Bot commented on HDFS-17761:
---------------------------------------
hfutatzhanghb commented on code in PR #7533:
URL: https://github.com/apache/hadoop/pull/7533#discussion_r2011948812
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNetworkTopologyServlet.java:
##########
@@ -24,33 +24,48 @@
import org.apache.hadoop.hdfs.server.federation.StateStoreDFSCluster;
import
org.apache.hadoop.hdfs.server.federation.resolver.MultipleDestinationMountTableResolver;
import org.apache.hadoop.io.IOUtils;
-import org.junit.BeforeClass;
-import org.junit.Test;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.extension.AfterAllCallback;
+import org.junit.jupiter.api.extension.BeforeEachCallback;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.extension.ExtensionContext;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
import java.io.ByteArrayOutputStream;
+import java.lang.reflect.Method;
import java.net.HttpURLConnection;
import java.net.URL;
import java.util.Iterator;
import java.util.Map;
import static
org.apache.hadoop.hdfs.server.federation.router.RBFConfigKeys.DFS_ROUTER_HTTP_ENABLE;
+import static
org.apache.hadoop.hdfs.server.federation.router.TestRouterNetworkTopologyServlet.clusterNoDatanodes;
+import static
org.apache.hadoop.hdfs.server.federation.router.TestRouterNetworkTopologyServlet.clusterWithDatanodes;
+import static
org.apache.hadoop.hdfs.server.federation.router.TestRouterNetworkTopologyServlet.setUp;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
public class TestRouterNetworkTopologyServlet {
- private static StateStoreDFSCluster clusterWithDatanodes;
- private static StateStoreDFSCluster clusterNoDatanodes;
+ static StateStoreDFSCluster clusterWithDatanodes;
+ static StateStoreDFSCluster clusterNoDatanodes;
Review Comment:
fixed, thanks.
> [ARR] RouterNetworkTopologyServlet adapts to async router rpc
> -------------------------------------------------------------
>
> Key: HDFS-17761
> URL: https://issues.apache.org/jira/browse/HDFS-17761
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> [ARR] RouterNetworkTopologyServlet adapts to async router rpc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
