[ 
https://issues.apache.org/jira/browse/HDFS-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938185#comment-17938185
 ] 

ASF GitHub Bot commented on HDFS-17761:
---------------------------------------

hfutatzhanghb commented on code in PR #7533:
URL: https://github.com/apache/hadoop/pull/7533#discussion_r2011936591


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterNetworkTopologyServlet.java:
##########
@@ -49,9 +51,19 @@ public void doGet(HttpServletRequest request, 
HttpServletResponse response)
     }
 
     Router router = RouterHttpServer.getRouterFromContext(context);
-    DatanodeInfo[] datanodeReport =
-        router.getRpcServer().getDatanodeReport(
-            HdfsConstants.DatanodeReportType.ALL);
+    DatanodeInfo[] datanodeReport = null;
+    if (router.getRpcServer().isAsync()) {
+      router.getRpcServer().getDatanodeReportAsync(
+          HdfsConstants.DatanodeReportType.ALL, true, 0);
+      try {
+        datanodeReport = syncReturn(DatanodeInfo[].class);
+      } catch (Exception e) {
+        throw new RuntimeException(e);
+      }

Review Comment:
   @KeeProMise Thanks for reviewing, have fixed~





> [ARR] RouterNetworkTopologyServlet adapts to async router rpc
> -------------------------------------------------------------
>
>                 Key: HDFS-17761
>                 URL: https://issues.apache.org/jira/browse/HDFS-17761
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Major
>              Labels: pull-request-available
>
> [ARR] RouterNetworkTopologyServlet adapts to async router rpc



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to