[ https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013131#comment-18013131 ]
ASF GitHub Bot commented on HDFS-12431: --------------------------------------- slfan1989 commented on code in PR #7864: URL: https://github.com/apache/hadoop/pull/7864#discussion_r2265535636 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNThroughputBenchmark.java: ########## @@ -31,19 +31,20 @@ import org.apache.hadoop.hdfs.protocol.DirectoryListing; import org.apache.hadoop.hdfs.protocol.HdfsFileStatus; import org.apache.hadoop.util.ExitUtil; -import org.junit.After; -import org.junit.Assert; -import org.junit.BeforeClass; -import org.junit.Test; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; public class TestNNThroughputBenchmark { - @BeforeClass - public static void setUp() { + @BeforeAll + public static void setUp() { Review Comment: check style issue. > Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs > ----------------------------------------------- > > Key: HDFS-12431 > URL: https://issues.apache.org/jira/browse/HDFS-12431 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Reporter: Ajay Kumar > Assignee: Hualong Zhang > Priority: Major > Labels: pull-request-available > Fix For: 3.5.0 > > > Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org