[
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011509#comment-18011509
]
ASF GitHub Bot commented on HDFS-12431:
---------------------------------------
ozkoca commented on code in PR #7841:
URL: https://github.com/apache/hadoop/pull/7841#discussion_r2248956743
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java:
##########
@@ -223,8 +222,8 @@ public static void reconfigureDataNode(DataNode dn, File...
newVols)
assertThat(
Review Comment:
nit: You may consider using `assertEquals`
```
assertEquals(
dn.getConf().get(DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY),
dn.reconfigurePropertyImpl(
DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY,
dnNewDataDirs.toString()));
```
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs
> -----------------------------------------------
>
> Key: HDFS-12431
> URL: https://issues.apache.org/jira/browse/HDFS-12431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
