[
https://issues.apache.org/jira/browse/HDFS-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215324#comment-13215324
]
Tsz Wo (Nicholas), SZE commented on HDFS-2990:
----------------------------------------------
> ... it looks like making things public and using interface annotations are
> the way forward for sharing more code between OEV / OIV and the NameNode.
The problem is that the interface and implementation separation is not clear.
If moving the code out from the NameNode is not easy, you may make things
public. In such case, you should do it with other changes that you are going
to make.
Thanks for taking a look.
> Move OfflineImageViewer, OfflineEditsViewer into the same package as the
> NameNode
> ---------------------------------------------------------------------------------
>
> Key: HDFS-2990
> URL: https://issues.apache.org/jira/browse/HDFS-2990
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-2990.patch
>
>
> Since OfflineImageviewer and OfflineEditsVeiwer are in different namespaces
> than the NameNode, we can't ruuse a lot of the code from the NameNode without
> making things public that we probably don't want to make public. Let's move
> them into the NameNode namespace to avoid this problem. These tools will
> always be tightly tied to the NameNode anyway (they are parsing the same
> on-disk structures, after all), so that is where they belong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
