[
https://issues.apache.org/jira/browse/HDFS-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron T. Myers updated HDFS-2920:
---------------------------------
Attachment: HDFS-2920-HDFS-1623.patch
Here's an updated patch on top of the one Todd posted, which should address
most remaining TODOs.
The differences between this patch and the last are:
* Remove TODOs from ClientProtocol regarding idempotency. setBalancerBandwidth
is indeed idemptoent. The other two are upgrade-related, which is out of scope
for HA.
* Remove two now-useless TODOs from FSImage, which were addressed by other
JIRAs.
* Remove TODO from NameNode about implementing checkHealth. Implement a simple
health check which just checks for available NN resources.
* Remove a TODO from NameNode about the need to handle partially-failed state
transitions. Implement delayed shutdown in case of failure to complete state
transition.
I left in two TODO(HA)s:
# TODOs regarding testing the BK journal manager. I filed HDFS-3022 to track
this.
# A seemingly low-priority TODO about a possible race condition when canceling
checkpoints. This race condition is relatively innocuous, as described in [this
comment|https://issues.apache.org/jira/browse/HDFS-2291?focusedCommentId=13177872&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13177872],
and is tracked by this JIRA: HDFS-2800
> HA: fix remaining TODO items
> ----------------------------
>
> Key: HDFS-2920
> URL: https://issues.apache.org/jira/browse/HDFS-2920
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Reporter: Eli Collins
> Assignee: Aaron T. Myers
> Attachments: HDFS-2920-HDFS-1623.patch, hdfs-2920-v1.txt
>
>
> There are a number of "TODO(HA)" and "TODO:HA" comments we need to fix or
> remove.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
