[
https://issues.apache.org/jira/browse/HDFS-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218320#comment-13218320
]
Eli Collins commented on HDFS-2920:
-----------------------------------
Hey ATM, how about putting the NN health check implementation and delayed
shutdown to separate jiras? They seem like discrete, self-contained changes
(and things we can handle post merge if we want, though I think we can iterate
on them quickly today). Only have a couple comments on these parts, everything
else is good to go.
- !nameNodeHasResourcesAvailable implies "The NameNode has run out of
resources" instead of the
"NameNode is low on resources". It would be even better if the message was more
specific (eg mentioned lack of inodes of disk space).
- Wrt delayed shutdown, we likely have (or should have) similar code elsewhere
right since there's nothing HA specific? Why is the shutdown delayed rather
than immediate?
- Wrt "Error encountered during state transition.", isn't the error most likely
due to a failure to start a service?
> HA: fix remaining TODO items
> ----------------------------
>
> Key: HDFS-2920
> URL: https://issues.apache.org/jira/browse/HDFS-2920
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Reporter: Eli Collins
> Assignee: Aaron T. Myers
> Attachments: HDFS-2920-HDFS-1623.patch, hdfs-2920-v1.txt
>
>
> There are a number of "TODO(HA)" and "TODO:HA" comments we need to fix or
> remove.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
