[ 
https://issues.apache.org/jira/browse/HDFS-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243247#comment-13243247
 ] 

Hadoop QA commented on HDFS-3164:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12520789/hdfs-3164.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 24 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/2140//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2140//console

This message is automatically generated.
                
> Move DatanodeInfo#hostName to DatanodeID
> ----------------------------------------
>
>                 Key: HDFS-3164
>                 URL: https://issues.apache.org/jira/browse/HDFS-3164
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3164.txt, hdfs-3164.txt
>
>
> Like HDFS-3138 (the ipcPort) the hostName field in DatanodeInfo is not 
> ephemeral and should be in DatanodeID. This also allows us to fixup the issue 
> where the DatanodeID#name field is overloaded (the DN sets it to a hostname, 
> then the NN clobbers it with an IP, and then the DN clobbers it's hostname 
> field with this IP). If the DN can specify both a "name" and "hostname" in 
> the DatanodeID then this code becomes simpler. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to