[ 
https://issues.apache.org/jira/browse/HDFS-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eli Collins updated HDFS-3208:
------------------------------

    Attachment: hdfs-3208.txt

Patch attached.

- Correctly construct DatanodeIDs when listing DNs that are in the hosts files 
but that we've never heard from (eg from a machine that's not been in the 
cluster for a long time or a bogus entry in the includes/excludes file). Update 
the tests to check this case.
- Remove the DatanodeRegistration constructor that takes an ipAddr w/o xferPort 
to make bugs like this harder to introduce
- Use default ports in DatanodeID instead of -1
- DM#resolveNetworkLocation is always given a hostname so no need to parse it 
out anymore  
- Better for DI#dumpDatanode to use getName not ipAddr

Aside from the new test I confirmed from the logs that putting a bogus hostname 
now results in the right report output and "Invalid hostname BOGUSHOST in hosts 
file" in the NN log.
                
> Bogus entries in hosts files are incorrectly displayed in the report 
> ---------------------------------------------------------------------
>
>                 Key: HDFS-3208
>                 URL: https://issues.apache.org/jira/browse/HDFS-3208
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3208.txt
>
>
> DM#getDatanodeListForReport incorrectly creates the DatanodeID for the "dead" 
> report for bogus entries in the host files (eg that an invalid hostname).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to