[ 
https://issues.apache.org/jira/browse/HDFS-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247835#comment-13247835
 ] 

Aaron T. Myers commented on HDFS-3208:
--------------------------------------

The patch looks pretty good to me. One little comment. +1 once this is 
addressed:

# Please use a constant for "BOGUSHOST" in TestDecommission.
                
> Bogus entries in hosts files are incorrectly displayed in the report 
> ---------------------------------------------------------------------
>
>                 Key: HDFS-3208
>                 URL: https://issues.apache.org/jira/browse/HDFS-3208
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3208.txt
>
>
> DM#getDatanodeListForReport incorrectly creates the DatanodeID for the "dead" 
> report for bogus entries in the host files (eg that an invalid hostname).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to