[
https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267806#comment-13267806
]
Tsz Wo (Nicholas), SZE commented on HDFS-3363:
----------------------------------------------
- BlockCollection and MutableBlockCollection should be in the blockmanagement
package. Then, services other than namenode can use them. Also, the javadoc
should not use the term "file".
- Remove BlockCollection.isDirectory() and the assert statement in
BlockManager.getReplication(Block block).
- Remove BlockCollection.isUnderConstruction() and replace the use of it in
blockmanagement by checking instanceof MutableBlockCollection.
- Rename getFullPathName() to getName(). It is the name of the collection but
not necessarily a path name.
- I agree with Daryn that we should rename BlocksMap.getINode(..) and, in
addition, the local variable names such as fileInode. We could do the rename
separately.
> blockmanagement should stop using INodeFile & INodeFileUC
> ----------------------------------------------------------
>
> Key: HDFS-3363
> URL: https://issues.apache.org/jira/browse/HDFS-3363
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 2.0.0, 3.0.0
> Reporter: John George
> Assignee: John George
> Priority: Minor
> Attachments: HDFS-3363.java
>
>
> Blockmanagement should stop using INodeFile and INodeFileUnderConstruction.
> One way would be to create an interface, like BlockColletion, that is passed
> along to the blockmanagement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
