[
https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268708#comment-13268708
]
Tsz Wo (Nicholas), SZE commented on HDFS-3363:
----------------------------------------------
- Move BlockCollection.setBlock(..) to MutableBlockCollection and change the
parameter in BlockManger.forceCompleteBlock(..) and completeBlock(..) to
MutableBlockCollection. We should also move setBlock(..) from INodeFile to
INodeFileUnderConstruction (this can be done separately.)
- need to update the following
{code}
//FSNamesystem.listCorruptFileBlocks(..)
String src = FSDirectory.getFullPathName(inode);
{code}
- revert the following: we don't need to cast it for null checking
{code}
//FSNamesystem
private boolean isValidBlock(Block b) {
- return (blockManager.getINode(b) != null);
+ return ((INodeFile) blockManager.getINode(b) != null);
}
{code}
- Need to rewrite the javadoc in BlockCollection and MutableBlockCollection
-* do not use "file"
-* do not mention INodeFile and INodeFileUnderConstruction
- revert the changes in TestBlockManager and FSEditLogLoader.
> blockmanagement should stop using INodeFile & INodeFileUC
> ----------------------------------------------------------
>
> Key: HDFS-3363
> URL: https://issues.apache.org/jira/browse/HDFS-3363
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 2.0.0, 3.0.0
> Reporter: John George
> Assignee: John George
> Priority: Minor
> Attachments: HDFS-3363.java, HDFS-3363.java
>
>
> Blockmanagement should stop using INodeFile and INodeFileUnderConstruction.
> One way would be to create an interface, like BlockColletion, that is passed
> along to the blockmanagement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
