[ 
https://issues.apache.org/jira/browse/HDFS-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270976#comment-13270976
 ] 

Brandon Li commented on HDFS-3388:
----------------------------------

So the root cause of the false-OK-response is due to the output stream close 
operation (response.getOutputStream().close()), which sends false-OK-response 
to client before HTTP server processes the uncaught exception.

I did a test with the above mentioned change and also make 
GetJournalEditServlet.doGet throw an Error.
Even though this error can't be caught by GetJournalEditServlet.doGet, it is 
handled by HTTP server and the client can get the error message.

Thanks, Nicholas.
                
> GetJournalEditServlet should catch more exceptions, not just IOException
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3388
>                 URL: https://issues.apache.org/jira/browse/HDFS-3388
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-3388.HDFS-3092.patch
>
>
> GetJournalEditServlet has the same problem as that of GetImageServlet 
> (HDFS-3330). It should be fixed in the same way. Also need to make 
> CheckpointFaultInjector visible for journal service tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to