[ 
https://issues.apache.org/jira/browse/HDFS-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272521#comment-13272521
 ] 

Brandon Li commented on HDFS-3388:
----------------------------------

Todd, it seems to be doable if we make the fault injector class as nested 
static class.
In term of the manageability of fault injector classes, people could argue that 
it might be better to keep all the fault injector classes in a different 
package. Let me upload the new path and see what other folks think. 
                
> GetJournalEditServlet should catch more exceptions, not just IOException
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3388
>                 URL: https://issues.apache.org/jira/browse/HDFS-3388
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-3388.HDFS-3092.patch
>
>
> GetJournalEditServlet has the same problem as that of GetImageServlet 
> (HDFS-3330). It should be fixed in the same way. Also need to make 
> CheckpointFaultInjector visible for journal service tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to