[
https://issues.apache.org/jira/browse/HDFS-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294996#comment-13294996
]
Miomir Boljanovic commented on HDFS-2988:
-----------------------------------------
Hi Todd,
Asserting that error message includes name of the jvm, may not be
straightforward in this case.
In TestCheckpoint.testSecondaryNameNodeLocking test,
GenericTestUtils.assertExceptionContains assertion is used to verify error
message
OverlappingFileLockException exception hanlder in tryLock() method however,
neither retrows nor wraps root cause exception but returns null.
Perhaps, I could assert that for given scenario method returns null, but that's
not what we are trying to test here?
> Improve error message when storage directory lock fails
> -------------------------------------------------------
>
> Key: HDFS-2988
> URL: https://issues.apache.org/jira/browse/HDFS-2988
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Todd Lipcon
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-2988.patch
>
>
> Currently, the error message is fairly opaque to a non-developer ("Cannot
> lock storage" or something). Instead, we should have some improvments:
> - when we create the in_use.lock file, we should write the hostname/PID that
> locked the file
> - if the lock fails, and in_use.lock exists, the error message should say
> something like "It appears that another namenode (pid 23423 on host
> foo.example.com) has already locked the storage directory."
> - if the lock fails, and no lock file exists, the error message should say
> something like "if this storage directory is mounted via NFS, ensure that the
> appropriate nfs lock services are running."
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
