[
https://issues.apache.org/jira/browse/HDFS-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408537#comment-13408537
]
Harsh J commented on HDFS-2988:
-------------------------------
I don't think the javadoc warnings are from his patch. I don't see any javadoc
warning changes in there:
{code}
+ * Test that, an attempt to lock a storage that is already locked by a
nodename,
+ * logs error message that includes JVM name of the namenode that locked it.
{code}
So it is/was probably something on the trunk. In any case, we can make sure to
run mvn javadoc:javadoc before committing this.
Minor nits:
# Fix typo in the fail(…) method. It has the word "alreaady" instead of
"already"
# The file.close() call can perhaps be moved to the finally { … } block at the
end?
+1 aside of these minor nits. Thanks!
> Improve error message when storage directory lock fails
> -------------------------------------------------------
>
> Key: HDFS-2988
> URL: https://issues.apache.org/jira/browse/HDFS-2988
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Todd Lipcon
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-2988.patch, HDFS-2988.patch, HDFS-2988.patch
>
>
> Currently, the error message is fairly opaque to a non-developer ("Cannot
> lock storage" or something). Instead, we should have some improvments:
> - when we create the in_use.lock file, we should write the hostname/PID that
> locked the file
> - if the lock fails, and in_use.lock exists, the error message should say
> something like "It appears that another namenode (pid 23423 on host
> foo.example.com) has already locked the storage directory."
> - if the lock fails, and no lock file exists, the error message should say
> something like "if this storage directory is mounted via NFS, ensure that the
> appropriate nfs lock services are running."
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
