[
https://issues.apache.org/jira/browse/HDFS-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434839#comment-13434839
]
Hadoop QA commented on HDFS-3802:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540945/HDFS-3802.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3010//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3010//console
This message is automatically generated.
> StartupOption.name in HdfsServerConstants should be final
> ---------------------------------------------------------
>
> Key: HDFS-3802
> URL: https://issues.apache.org/jira/browse/HDFS-3802
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HDFS-3802.patch
>
>
> In HdfsServerConstants, it may be better to define StartupOption.name as
> final since it will not and should not be modified after initialization. For
> example, in NameNode.java, the printUsage function prints out multiple
> startup options' names. The modification/change of the StartupOption.name may
> cause invalid usage message. Although right now there is no methods to
> change/set the value of StartupOption.name, it is better to add the final
> keyword to make sure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
