[
https://issues.apache.org/jira/browse/HDFS-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HDFS-3802:
-----------------------------------------
Affects Version/s: (was: 3.0.0)
Fix Version/s: (was: 3.0.0)
Hadoop Flags: Reviewed
+1 patch looks good.
> StartupOption.name in HdfsServerConstants should be final
> ---------------------------------------------------------
>
> Key: HDFS-3802
> URL: https://issues.apache.org/jira/browse/HDFS-3802
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Priority: Trivial
> Attachments: HDFS-3802.patch
>
>
> In HdfsServerConstants, it may be better to define StartupOption.name as
> final since it will not and should not be modified after initialization. For
> example, in NameNode.java, the printUsage function prints out multiple
> startup options' names. The modification/change of the StartupOption.name may
> cause invalid usage message. Although right now there is no methods to
> change/set the value of StartupOption.name, it is better to add the final
> keyword to make sure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira