[ 
https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435622#comment-13435622
 ] 

Daryn Sharp commented on HDFS-3804:
-----------------------------------

The 2nd half of the tests need to ensure they get a new fs instance each time.  
Getting a new fs instance for all tests isn't a bad thing though.  If one test 
changes the internal state of the fs (say changeWorkingDirectory, etc), it can 
contaminate the other tests.  It frustrates the poor dev trying to figure out 
why their simple tests don't work -- hint: whose comment do you think that is? 
:)

Something like this is what I think is needed.
{code}
@Before
public void setupFs() {
  hdfs = ...;
  hftpFs = ...;
}
@After
public void resetFsCache() {
  FileSystem.closeAll();
}
{code}
                
> TestHftpFileSystem fails intermittently with JDK7
> -------------------------------------------------
>
>                 Key: HDFS-3804
>                 URL: https://issues.apache.org/jira/browse/HDFS-3804
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>         Environment: Apache Maven 3.0.4
> Maven home: /usr/share/maven
> Java version: 1.7.0_04, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/jdk1.7.0_04/jre
> Default locale: en_US, platform encoding: ISO-8859-1
> OS name: "linux", version: "3.2.0-25-generic", arch: "amd64", family: "unix"
>            Reporter: Trevor Robinson
>            Assignee: Trevor Robinson
>              Labels: java7
>         Attachments: HDFS-3804.patch
>
>
> For example:
>   testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem 
> closed
>   testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem 
> closed
> This test case sets up a filesystem that is used by the first half of the 
> test methods (in declaration order), but the second half of the tests start 
> by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an 
> arbitrary order, so if any first half methods run after any second half 
> methods, they fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to