[ 
https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435626#comment-13435626
 ] 

Trevor Robinson commented on HDFS-3804:
---------------------------------------

I understand what you're suggesting, and wasn't concerned about a new FS 
instance for each test. I agree that @Before/After is a better choice than 
@BeforeClass/AfterClass, since saving a millisecond isn't worth the fragility.

My point was just that, based on your code comment, it seemed like the 
filesystem created by setUp would interfere with the filesystems the 2nd half 
tests were creating. However, I went ahead and tried out the change, and it 
passed, so I guess that doesn't matter.
                
> TestHftpFileSystem fails intermittently with JDK7
> -------------------------------------------------
>
>                 Key: HDFS-3804
>                 URL: https://issues.apache.org/jira/browse/HDFS-3804
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>         Environment: Apache Maven 3.0.4
> Maven home: /usr/share/maven
> Java version: 1.7.0_04, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/jdk1.7.0_04/jre
> Default locale: en_US, platform encoding: ISO-8859-1
> OS name: "linux", version: "3.2.0-25-generic", arch: "amd64", family: "unix"
>            Reporter: Trevor Robinson
>            Assignee: Trevor Robinson
>              Labels: java7
>         Attachments: HDFS-3804-2.patch, HDFS-3804.patch
>
>
> For example:
>   testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem 
> closed
>   testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem 
> closed
> This test case sets up a filesystem that is used by the first half of the 
> test methods (in declaration order), but the second half of the tests start 
> by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an 
> arbitrary order, so if any first half methods run after any second half 
> methods, they fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to